From 98f20eb94b2236dd1a25f9678669580732010041 Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Tue, 20 Sep 2022 13:31:49 +0200 Subject: [PATCH 1/2] updating migration docs with additional ics27 host parameter --- docs/migrations/v4-to-v5.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/docs/migrations/v4-to-v5.md b/docs/migrations/v4-to-v5.md index 8858516dd7d..b6b50aef6dd 100644 --- a/docs/migrations/v4-to-v5.md +++ b/docs/migrations/v4-to-v5.md @@ -38,6 +38,25 @@ The `AnteDecorator` was actually renamed twice, but in [this PR](https://github. ## IBC Apps +### ICS27 - Interchain Accounts + +An additional parameter, `ics4Wrapper` has been added to the `host` submodule `NewKeeper` function in `modules/apps/27-interchain-accounts/host/keeper`. +This allows the `host` submodule to correctly unwrap the channel version for channel reopening handshakes in the `OnChanOpenTry` callback. + +```diff +func NewKeeper( + cdc codec.BinaryCodec, + key storetypes.StoreKey, + paramSpace paramtypes.Subspace, ++ ics4Wrapper icatypes.ICS4Wrapper, + channelKeeper icatypes.ChannelKeeper, + portKeeper icatypes.PortKeeper, + accountKeeper icatypes.AccountKeeper, + scopedKeeper icatypes.ScopedKeeper, + msgRouter icatypes.MessageRouter, +) Keeper +``` + ### Core The `key` parameter of the `NewKeeper` function in `modules/core/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`): From fbfa045b8b54ea21a570a88397952ad1db52f236 Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Tue, 20 Sep 2022 13:45:32 +0200 Subject: [PATCH 2/2] fix indentation --- docs/migrations/v4-to-v5.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migrations/v4-to-v5.md b/docs/migrations/v4-to-v5.md index b6b50aef6dd..f16bf331536 100644 --- a/docs/migrations/v4-to-v5.md +++ b/docs/migrations/v4-to-v5.md @@ -51,7 +51,7 @@ func NewKeeper( + ics4Wrapper icatypes.ICS4Wrapper, channelKeeper icatypes.ChannelKeeper, portKeeper icatypes.PortKeeper, - accountKeeper icatypes.AccountKeeper, + accountKeeper icatypes.AccountKeeper, scopedKeeper icatypes.ScopedKeeper, msgRouter icatypes.MessageRouter, ) Keeper