Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proto-lint fails #642

Closed
3 tasks
colin-axner opened this issue Dec 17, 2021 · 0 comments · Fixed by #781
Closed
3 tasks

make proto-lint fails #642

colin-axner opened this issue Dec 17, 2021 · 0 comments · Fixed by #781
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@colin-axner
Copy link
Contributor

Summary

 make proto-lint
{"path":"proto/ibc/applications/interchain_accounts/controller/v1/controller.proto","start_line":7,"start_column":1,"end_line":7,"end_column":36,"type":"IMPORT_USED","message":"Import \"google/protobuf/any.proto\" is unused."}
{"path":"proto/ibc/applications/interchain_accounts/controller/v1/query.proto","start_line":7,"start_column":1,"end_line":7,"end_column":31,"type":"IMPORT_USED","message":"Import \"gogoproto/gogo.proto\" is unused."}
{"path":"proto/ibc/applications/interchain_accounts/host/v1/host.proto","start_line":7,"start_column":1,"end_line":7,"end_column":36,"type":"IMPORT_USED","message":"Import \"google/protobuf/any.proto\" is unused."}
{"path":"proto/ibc/applications/interchain_accounts/host/v1/query.proto","start_line":8,"start_column":1,"end_line":8,"end_column":31,"type":"IMPORT_USED","message":"Import \"gogoproto/gogo.proto\" is unused."}
{"path":"third_party/proto/proofs.proto","start_line":3,"start_column":1,"end_line":3,"end_column":15,"type":"PACKAGE_DIRECTORY_MATCH","message":"Files with package \"ics23\" must be within a directory \"ics23\" relative to root but were in directory \".\"."}
{"path":"third_party/proto/proofs.proto","start_line":6,"start_column":1,"end_line":14,"end_column":2,"type":"COMMENT_ENUM","message":"Enum \"HashOp\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":8,"start_column":5,"end_line":8,"end_column":12,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"NO_HASH\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":8,"start_column":5,"end_line":8,"end_column":12,"type":"ENUM_ZERO_VALUE_SUFFIX","message":"Enum zero value name \"NO_HASH\" should be suffixed with \"_UNSPECIFIED\"."}
{"path":"third_party/proto/proofs.proto","start_line":9,"start_column":5,"end_line":9,"end_column":16,"type":"COMMENT_ENUM_VALUE","message":"Enum value \"SHA256\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":9,"start_column":5,"end_line":9,"end_column":11,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"SHA256\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":10,"start_column":5,"end_line":10,"end_column":16,"type":"COMMENT_ENUM_VALUE","message":"Enum value \"SHA512\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":10,"start_column":5,"end_line":10,"end_column":11,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"SHA512\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":11,"start_column":5,"end_line":11,"end_column":16,"type":"COMMENT_ENUM_VALUE","message":"Enum value \"KECCAK\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":11,"start_column":5,"end_line":11,"end_column":11,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"KECCAK\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":12,"start_column":5,"end_line":12,"end_column":19,"type":"COMMENT_ENUM_VALUE","message":"Enum value \"RIPEMD160\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":12,"start_column":5,"end_line":12,"end_column":14,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RIPEMD160\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":13,"start_column":5,"end_line":13,"end_column":17,"type":"COMMENT_ENUM_VALUE","message":"Enum value \"BITCOIN\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":13,"start_column":5,"end_line":13,"end_column":12,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"BITCOIN\" should be prefixed with \"HASH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":24,"start_column":5,"end_line":24,"end_column":14,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"NO_PREFIX\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":24,"start_column":5,"end_line":24,"end_column":14,"type":"ENUM_ZERO_VALUE_SUFFIX","message":"Enum zero value name \"NO_PREFIX\" should be suffixed with \"_UNSPECIFIED\"."}
{"path":"third_party/proto/proofs.proto","start_line":26,"start_column":5,"end_line":26,"end_column":14,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"VAR_PROTO\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":28,"start_column":5,"end_line":28,"end_column":12,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"VAR_RLP\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":30,"start_column":5,"end_line":30,"end_column":16,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"FIXED32_BIG\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":32,"start_column":5,"end_line":32,"end_column":19,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"FIXED32_LITTLE\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":34,"start_column":5,"end_line":34,"end_column":16,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"FIXED64_BIG\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":36,"start_column":5,"end_line":36,"end_column":19,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"FIXED64_LITTLE\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":38,"start_column":5,"end_line":38,"end_column":21,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"REQUIRE_32_BYTES\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":40,"start_column":5,"end_line":40,"end_column":21,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"REQUIRE_64_BYTES\" should be prefixed with \"LENGTH_OP_\"."}
{"path":"third_party/proto/proofs.proto","start_line":86,"start_column":5,"end_line":91,"end_column":6,"type":"COMMENT_ONEOF","message":"Oneof \"proof\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":200,"start_column":3,"end_line":203,"end_column":4,"type":"COMMENT_ONEOF","message":"Oneof \"proof\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":209,"start_column":1,"end_line":212,"end_column":2,"type":"COMMENT_MESSAGE","message":"Message \"CompressedBatchProof\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":216,"start_column":3,"end_line":219,"end_column":4,"type":"COMMENT_ONEOF","message":"Oneof \"proof\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":222,"start_column":1,"end_line":228,"end_column":2,"type":"COMMENT_MESSAGE","message":"Message \"CompressedExistenceProof\" should have a non-empty comment for documentation."}
{"path":"third_party/proto/proofs.proto","start_line":230,"start_column":1,"end_line":234,"end_column":2,"type":"COMMENT_MESSAGE","message":"Message \"CompressedNonExistenceProof\" should have a non-empty comment for documentation."}
make: *** [Makefile:392: proto-lint] Error 100

We should remove ics23 commitment proto files from linting (third_party) and fix the linting issues in our proto files


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants