Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine functions TestGetSourceCallbackDataTransfer and TestGetDestCallbackDataTransfer #6358

Open
3 tasks
DimitrisJim opened this issue May 22, 2024 · 1 comment
Open
3 tasks

Combine functions TestGetSourceCallbackDataTransfer and TestGetDestCallbackDataTransfer #6358

DimitrisJim opened this issue May 22, 2024 · 1 comment
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

Encountered during #6354

These two functions in types/callbacks.go seem like they should be able to be compined into a single function that uses table tests.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces labels May 22, 2024
@DimitrisJim DimitrisJim changed the title Compine functions TestGetSourceCallbackDataTransfer and TestGetDestCallbackDataTransfer Combine functions TestGetSourceCallbackDataTransfer and TestGetDestCallbackDataTransfer May 27, 2024
@hastur199 hastur199 mentioned this issue May 27, 2024
Closed
10 tasks
@coderabbitai coderabbitai bot mentioned this issue May 29, 2024
Merged
10 tasks
@chatton
Copy link
Contributor

chatton commented Aug 26, 2024

we can use the suggestions made in the comments of #6400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
2 participants
@chatton @DimitrisJim