Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume flat gas fee on VerifyMembership rpc #5902

Closed
3 tasks
damiannolan opened this issue Feb 26, 2024 · 0 comments · Fixed by #5927
Closed
3 tasks

Consume flat gas fee on VerifyMembership rpc #5902

damiannolan opened this issue Feb 26, 2024 · 0 comments · Fixed by #5927
Assignees
@charleenfei
Labels
02-client type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Rollkit integration

Comments

@damiannolan
Copy link
Contributor

damiannolan commented Feb 26, 2024 •
edited
Loading

Summary

Consume a flat gas fee on the meter in the VerifyMembership rpc handler based on len(msg.Proof).
This could be multiplied by some sane default or configurable value.

This should provide some low level of defence against clients calling one another in chain. Consuming a flat fee should incur an error: out of gas in situations described above.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 02-client labels Feb 26, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Feb 26, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Feb 26, 2024
@charleenfei charleenfei self-assigned this Feb 29, 2024
@damiannolan damiannolan moved this from Todo 🏃 to In progress 👷 in ibc-go Mar 5, 2024
@charleenfei charleenfei mentioned this issue Mar 5, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go Mar 12, 2024
@mergify mergify bot mentioned this issue Apr 8, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
02-client type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
No open projects
ibc-go
Archived in project
Milestone
Rollkit integration
Development

Successfully merging a pull request may close this issue.

imp: add flat fee for queries to VerifyMembership cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @charleenfei