Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StoreCodeUnchecked instead of StoreCode in snapshotter/init genesis. #5155

Closed
3 tasks
DimitrisJim opened this issue Nov 22, 2023 · 2 comments · Fixed by #5167
Closed
3 tasks

Use StoreCodeUnchecked instead of StoreCode in snapshotter/init genesis. #5155

DimitrisJim opened this issue Nov 22, 2023 · 2 comments · Fixed by #5167
Assignees
@GNaD13
Labels
08-wasm
Milestone
08-wasm/v0.1.0

Comments

@DimitrisJim
Copy link
Contributor

This was brought up by @alpe on slack a while back:

yes, use StoreCodeUnchecked for genesis import/ state sync. This will ensure that the files are restored whatever the current constraints for new files are

Should amend snapshotter's restore and InitGenesis to do this.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@GNaD13
Copy link
Contributor

GNaD13 commented Nov 22, 2023

Hi @DimitrisJim, can I take this issue?

@DimitrisJim
Copy link
Contributor Author

absolutely @GNaD13, thanks 🙏!

@DimitrisJim DimitrisJim moved this to Todo in ibc-go Nov 22, 2023
@GNaD13 GNaD13 mentioned this issue Nov 23, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Nov 24, 2023
@crodriguezvega crodriguezvega added this to the 08-wasm/v0.1.0 milestone Nov 24, 2023
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Nov 27, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GNaD13 GNaD13

Labels
08-wasm
Projects
ibc-go
Archived in project
Milestone
08-wasm/v0.1.0
Development

Successfully merging a pull request may close this issue.

Change to StoreCodeUnchecked in Genesis and snapshotter GNaD13/ibc-go
3 participants
@crodriguezvega @DimitrisJim @GNaD13