SendPacket Callback validation can be bypassed by the IBC Actor #4567
Labels
callbacks middleware
Issues for callbacks middleware
change: state machine breaking
Issues or PRs that break consensus (need to be released in at least a new minor version)
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
Summary of Bug
If
IBCSendPacketCallback
does not panic on out of gas, and instead it returns nil (whilecachedCtx.GasMeter().IsPastLimit()
is true). Then SendPacket callback will be skipped and transaction committed ifAllowRetry
is false.Expected Behaviour
The packet should not be sent unless
IBCSendPacketCallback
returnsnil
explicitly.Version
modules/apps/callbacks/v0.1.0+ibc-go-v7.3
Steps to Reproduce
This error is reproduced in here. ProcessCallback should NOT return
nil
in this case.For Admin Use
The text was updated successfully, but these errors were encountered: