Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendPacket Callback validation can be bypassed by the IBC Actor #4567

Closed
3 tasks
srdtrk opened this issue Sep 5, 2023 · 1 comment
Closed
3 tasks

SendPacket Callback validation can be bypassed by the IBC Actor #4567

srdtrk opened this issue Sep 5, 2023 · 1 comment
Labels
callbacks middleware Issues for callbacks middleware change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@srdtrk
Copy link
Member

srdtrk commented Sep 5, 2023 •
edited
Loading

Summary of Bug

If IBCSendPacketCallback does not panic on out of gas, and instead it returns nil (while cachedCtx.GasMeter().IsPastLimit() is true). Then SendPacket callback will be skipped and transaction committed if AllowRetry is false.

Expected Behaviour

The packet should not be sent unless IBCSendPacketCallback returns nil explicitly.

Version

modules/apps/callbacks/v0.1.0+ibc-go-v7.3

Steps to Reproduce

This error is reproduced in here. ProcessCallback should NOT return nil in this case.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@srdtrk srdtrk added type: bug Something isn't working as expected change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) callbacks middleware Issues for callbacks middleware labels Sep 5, 2023
@srdtrk srdtrk mentioned this issue Sep 5, 2023
Merged
9 tasks
@srdtrk srdtrk added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. and removed type: bug Something isn't working as expected labels Sep 5, 2023
@srdtrk
Copy link
Member Author

srdtrk commented Sep 7, 2023

#4568

@srdtrk srdtrk closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
callbacks middleware Issues for callbacks middleware change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srdtrk