Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate ibc authority to 04-channel to be used within upgrade cancellation #4420

Closed
3 tasks
damiannolan opened this issue Aug 22, 2023 · 2 comments
Closed
3 tasks
Assignees
Labels
04-channel channel-upgradability Channel upgradability feature

Comments

@damiannolan
Copy link
Member

Summary

The authority of the ibc module is required in order to do some privileged action when performing a cancellation of an upgrade.

We should determine how we want to access the authority from the 04-channel submodule, and other submodule if required in future. The authority currently exists as a field on the IBCKeeper and is exposed through the GetAuthority method. However, submodule keepers composed within the IBCKeeper cannot reach this.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added 04-channel channel-upgradability Channel upgradability feature labels Aug 22, 2023
@damiannolan damiannolan added this to the 04-channel upgrades beta milestone Aug 22, 2023
@damiannolan damiannolan added the needs discussion Issues that need discussion before they can be worked on label Aug 22, 2023
@damiannolan
Copy link
Member Author

Adding needs-discussion label so we can align on the approach here prior to completing the issue

@damiannolan
Copy link
Member Author

After discussion, let's check msg.Signer against k.GetAuthority in the msg server handler and pass a bool to 04-channel in order to infer if it is an authorized upgrader or not. This decides whether or not proof verification is carried out

@damiannolan damiannolan removed the needs discussion Issues that need discussion before they can be worked on label Aug 28, 2023
@charleenfei charleenfei self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants