Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on counterparty upgrade timeout in ack handler #4259

Closed
3 tasks
colin-axner opened this issue Aug 2, 2023 · 0 comments
Closed
3 tasks

Add check on counterparty upgrade timeout in ack handler #4259

colin-axner opened this issue Aug 2, 2023 · 0 comments
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@colin-axner
Copy link
Contributor

Summary

From the spec changes

  timeout = counterpartyUpgrade.timeout
    
    // counterparty-specified timeout must not have exceeded
    // if it has, then restore the channel and abort upgrade handshake
    if (timeout.timeoutHeight != 0 && currentHeight() >= timeout.timeoutHeight) ||
          (timeout.timeoutTimestamp != 0 && currentTimestamp() >= timeout.timeoutTimestamp ) {
            restoreChannel(portIdentifier, channelIdentifier)
    }

In the ack handler, if the counterparty upgrade timeout deadline has elapsed, return an upgrade error so the upgrade is aborted


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants