Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call verification of upgrade and channel before start flush in ack handler #4254

Closed
3 tasks
Tracked by #4255
colin-axner opened this issue Aug 2, 2023 · 0 comments
Closed
3 tasks
Tracked by #4255
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@colin-axner
Copy link
Contributor

Summary

startFlushUpgradeHandshake will be remade to be a write function. In order to do this we will pull out the verify functions. We will start by adding duplicate verify funcs and then remove the verify funcs from start flush when they are no longer needed.

Add the same verification done here to the upgrade ack handler here

A followup issue will be opened to create a helper function for the upgrade verification


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the channel-upgradability Channel upgradability feature label Aug 2, 2023
@colin-axner colin-axner added this to the 04-channel upgrades alpha milestone Aug 2, 2023
@colin-axner colin-axner changed the title Call verification of upgrade and channel before start flush in try handler Call verification of upgrade and channel before start flush in ack handler Aug 2, 2023
@DimitrisJim DimitrisJim self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants