Simplify IBC app callback lookup #3817
Labels
needs discussion
Issues that need discussion before they can be worked on
nice-to-have
type: code hygiene
Clean up code but without changing functionality or interfaces
Milestone
Summary
Simplify the application callback lookup
Problem Definition
Currently the
msg_server.go
performs a repetitive calls toLookupModuleByPort
andLookupModuleByChannel
. These function are only used to get themodule
which is then passed tok.Router.GetRoute(module)
to obtain the application callbacks.Currently some of the calls to these lookup function use the returned capability, but this will likely be removed after this spec issue is addressed.
Proposal
We can likely reduce this 2 step lookup into one call:
Another alternative is to have the port keeper implement each callback function, such that you call through the port keeper:
For Admin Use
The text was updated successfully, but these errors were encountered: