Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper functions for publishing of packet sent and acknowledgement sent events #335

Closed
3 tasks
crodriguezvega opened this issue Aug 13, 2021 · 0 comments · Fixed by #343
Closed
3 tasks
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@crodriguezvega
Copy link
Contributor

Summary

We currently have some helper functions for publishing events on packet received, packet acknowledged and packet timed out.

https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/events.go

We also emit events for packet sent (here) and acknowledgement sent (here), but those do not have a helper function.

The proposal is to create helper functions for these two events as well. The rationale is to make both packet event emitting code and the code of the functions using it more similar.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant