Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename icatypes.PortPrefix to icatypes.ControllerPortPrefix #2433

Closed
3 tasks
colin-axner opened this issue Sep 29, 2022 · 5 comments · Fixed by #2450
Closed
3 tasks

Rename icatypes.PortPrefix to icatypes.ControllerPortPrefix #2433

colin-axner opened this issue Sep 29, 2022 · 5 comments · Fixed by #2450
Assignees
@alizahidraja
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Sep 29, 2022 •
edited by crodriguezvega
Loading

Summary

I think it'd be useful to make the naming a bit more explicit. I often need to double check what the actual value is here. "Prefix" does imply it is the controller since the host doesn't really have a prefix, but I think it'd still be useful to update the naming to "ControllerPortPrefix"

Rename icatypes.PortPrefix to icatypes.ControllerPortPrefix

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Sep 29, 2022
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Sep 29, 2022
@crodriguezvega
Copy link
Contributor

Should we also rename PortID to HostPortID?

@colin-axner
Copy link
Contributor Author

Yea that sounds good to me

@alizahidraja
Copy link
Contributor

Is the issue open? Would like to work on it

@crodriguezvega
Copy link
Contributor

Is the issue open? Would like to work on it

It is! Thanks so much to being so active on the repo!

@alizahidraja
Copy link
Contributor

My pleasure 😄

@alizahidraja alizahidraja mentioned this issue Sep 30, 2022
Merged
9 tasks
@damiannolan damiannolan mentioned this issue Oct 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizahidraja alizahidraja

Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix alizahidraja/ibc-go
3 participants
@crodriguezvega @colin-axner @alizahidraja