Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use 4 val nodes for e2e tests #2016

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Conversation

seantking
Copy link
Contributor

@seantking seantking commented Aug 16, 2022

Description

Using 4 validator nodes instead of 1 for e2e tests.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once they all pass 🥇

@seantking
Copy link
Contributor Author

Interested to see if the tests take much longer to run

@seantking
Copy link
Contributor Author

Seems like the tests are failing with some network issues.

@seantking seantking marked this pull request as draft August 17, 2022 09:16
@seantking seantking marked this pull request as ready for review August 22, 2022 14:51
@seantking seantking changed the title refactor: use 3 val nodes for e2e tests refactor: use 4 val nodes for e2e tests Aug 22, 2022
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@seantking seantking enabled auto-merge (squash) August 23, 2022 15:05
@seantking seantking merged commit 05c4bfb into main Aug 23, 2022
@seantking seantking deleted the sean/e2e-test-3-vals branch August 23, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants