Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade timeout rpc to 04-channel protobuf Msg service #1625

Closed
4 of 7 tasks
damiannolan opened this issue Jun 30, 2022 · 1 comment
Closed
4 of 7 tasks

Add upgrade timeout rpc to 04-channel protobuf Msg service #1625

damiannolan opened this issue Jun 30, 2022 · 1 comment

Comments

@damiannolan
Copy link
Member

damiannolan commented Jun 30, 2022

Summary

It is possible for the channel upgrade process to stall indefinitely on UPGRADE_TRY if the UPGRADE_TRY transaction simply cannot pass on the counterparty; for example, the upgrade feature may not be enabled on the counterparty chain.

In this case, we do not want the initializing chain to be stuck indefinitely in the UPGRADE_INIT step. Thus, the UpgradeInit message will contain a TimeoutHeight and TimeoutTimestamp. The counterparty chain is expected to reject UpgradeTry message if the specified timeout has already elapsed.

A relayer must then submit an ChanUpgradeTimeoutMsg message to the initializing chain which proves that the counterparty is still in its original state. If the proof succeeds, then the initializing chain shall also restore its original channel and cancel the upgrade.

rpc ChannelUpgradeTimeout(MsgChannelUpgradeTimeout) returns (MsgChannelUpgradeTimeoutResponse);

Implement the ChannelUpgradeTimeout functionality as defined in ICS004 - Upgrade Handshake:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jun 30, 2022
@damiannolan damiannolan self-assigned this Jun 30, 2022
@damiannolan damiannolan mentioned this issue Jun 30, 2022
10 tasks
@charleenfei charleenfei removed their assignment Jun 2, 2023
@DimitrisJim
Copy link
Contributor

seems like this wasn't closed, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants