Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove localhost client #1089

Closed
3 tasks
colin-axner opened this issue Mar 9, 2022 · 2 comments
Closed
3 tasks

Remove localhost client #1089

colin-axner opened this issue Mar 9, 2022 · 2 comments
Assignees
Labels
02-client 09-localhost needs discussion Issues that need discussion before they can be worked on

Comments

@colin-axner
Copy link
Contributor

Summary

The localhost client is currently non-functional. We should either fix it or remove it so there is no confusion. I propose we remove it. The existing code is minimal and I think it'd be easy enough to reimplement it from scratch if we so desire. There was an existing proposed ADR on how to fix the implementation, but it's still very unclear when a use case for the localhost will arise (thus far no one has asked for it to be functional)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added 09-localhost needs discussion Issues that need discussion before they can be worked on 02-client labels Mar 9, 2022
@crodriguezvega
Copy link
Contributor

Can we use this as a learning exercise? Is there anything valuable about IBC and/or light clients that could be learnt from fixing/re-implementing this?

@crodriguezvega
Copy link
Contributor

We decided to remove it. 🔥

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Mar 22, 2022
@seantking seantking self-assigned this Mar 29, 2022
@seantking seantking moved this from Todo to In review in ibc-go Mar 29, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
Repository owner moved this from In review to Done in ibc-go Mar 31, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02-client 09-localhost needs discussion Issues that need discussion before they can be worked on
Projects
No open projects
Status: Done 🥳
Development

No branches or pull requests

3 participants