Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware doesn't allow for IBC app version usage after handshake completion #1002

Closed
3 tasks
colin-axner opened this issue Feb 24, 2022 · 1 comment · Fixed by #1022
Closed
3 tasks

Middleware doesn't allow for IBC app version usage after handshake completion #1002

colin-axner opened this issue Feb 24, 2022 · 1 comment · Fixed by #1022
Assignees

Comments

@colin-axner
Copy link
Contributor

Summary

After the handshake is completed, the version is done being negotiated and is set in the channel state. The current design of middleware recommends to wrap the underlying applications version into your own metadata. This becomes problematic when an application wants to reference its own version during the packet lifecycle.

Opening for discussion as this is problematic to any existing applications which currently make use of the version (none of our applications do for the packet life cycle)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the needs discussion Issues that need discussion before they can be worked on label Feb 24, 2022
@colin-axner colin-axner self-assigned this Feb 28, 2022
@colin-axner
Copy link
Contributor Author

Last I discussed with @AdityaSripal, there were two options he presented:

  • Add a GetChannelVersion to the ICS4Wrapper interface
  • Expect IBC applications to do extra storing to account for this issue

I think we should go with the first option as it isn't much overhead. We are consistently running into issues with middleware wrapping the underlying applications, so we should investigate a longer term fix

@crodriguezvega crodriguezvega moved this to In progress in ibc-go Mar 7, 2022
@crodriguezvega crodriguezvega added this to the Q2-2022-backlog milestone Mar 31, 2022
@colin-axner colin-axner moved this from In progress to In review in ibc-go Apr 14, 2022
@colin-axner colin-axner added 04-channel and removed needs discussion Issues that need discussion before they can be worked on labels Apr 14, 2022
Repository owner moved this from In review to Done in ibc-go Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants