You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’ve been exploring the 08-wasm keeper module and noticed that some methods in the Keeper struct use pointer receivers (e.g., setQueryPlugins and SetQueryPlugins), while others use value receivers (e.g., GetQueryPlugins and GetChecksums).
I understand that pointer receivers are necessary when modifying the receiver’s state, while value receivers are sufficient for read-only operations. However, for consistency and clarity within the 08-wasm keeper module, would it make sense to standardize all methods to use pointer receivers, even for read-only operations?
Are there specific design considerations or performance implications that led to the current mix of receiver types in this module? I’d appreciate any insights you could share on this decision.
Thank you for your time and contributions to the project!
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I’ve been exploring the 08-wasm keeper module and noticed that some methods in the Keeper struct use pointer receivers (e.g., setQueryPlugins and SetQueryPlugins), while others use value receivers (e.g., GetQueryPlugins and GetChecksums).
I understand that pointer receivers are necessary when modifying the receiver’s state, while value receivers are sufficient for read-only operations. However, for consistency and clarity within the 08-wasm keeper module, would it make sense to standardize all methods to use pointer receivers, even for read-only operations?
Are there specific design considerations or performance implications that led to the current mix of receiver types in this module? I’d appreciate any insights you could share on this decision.
Thank you for your time and contributions to the project!
Beta Was this translation helpful? Give feedback.
All reactions