From 817198bf22afd9e7d90f9a2f5fc21fbe5e22b3c7 Mon Sep 17 00:00:00 2001 From: srdtrk Date: Tue, 7 May 2024 11:34:38 +0800 Subject: [PATCH] nit: damian --- modules/apps/transfer/ibc_module.go | 4 +--- modules/apps/transfer/ibc_module_test.go | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/apps/transfer/ibc_module.go b/modules/apps/transfer/ibc_module.go index 861138941d6..1424260f178 100644 --- a/modules/apps/transfer/ibc_module.go +++ b/modules/apps/transfer/ibc_module.go @@ -112,7 +112,6 @@ func (im IBCModule) OnChanOpenTry( counterparty channeltypes.Counterparty, counterpartyVersion string, ) (string, error) { - logger := im.keeper.Logger(ctx) if err := ValidateTransferChannelParams(ctx, im.keeper, order, portID, channelID); err != nil { return "", err } @@ -124,8 +123,7 @@ func (im IBCModule) OnChanOpenTry( if counterpartyVersion != types.Version { // Propose the current version - logger.Debug(fmt.Sprintf("invalid counterparty version: expected %s, got %s", types.Version, counterpartyVersion)) - logger.Debug(fmt.Sprintf("proposing the current version: %s", types.Version)) + im.keeper.Logger(ctx).Debug("invalid counterparty version, proposing current app version", "counterpartyVersion", counterpartyVersion, "version", types.Version) return types.Version, nil } diff --git a/modules/apps/transfer/ibc_module_test.go b/modules/apps/transfer/ibc_module_test.go index 79e1626b4d7..4017134a999 100644 --- a/modules/apps/transfer/ibc_module_test.go +++ b/modules/apps/transfer/ibc_module_test.go @@ -132,7 +132,7 @@ func (suite *TransferTestSuite) TestOnChanOpenTry() { "success", func() {}, nil, }, { - "success: invalid counterparty version", func() { + "success: invalid counterparty version proposes new version", func() { // transfer module will propose the default version counterpartyVersion = "version" }, nil,