x/globalfee/ante: CombinedFeeRequirement could be simplified from many redundant else clauses by a simple composite check

[odeke-em]

Summary

Noticed during an audit that this code

gaia/x/globalfee/ante/fee_utils.go

Lines 135 to 147 in 44ca2bb

	for _, fee := range globalFees {
	// min_gas_price denom in global fee
	ok, c := minGasPrices.Find(fee.Denom)
	if ok {
	if c.Amount.GT(fee.Amount) {
	allFees = append(allFees, c)
	} else {
	allFees = append(allFees, fee)
	}
	} else {
	allFees = append(allFees, fee)
	}
	}

got a bunch of else clauses that translate essentially to:

if we already have a value c inside minGasPrices sharing the same denomination as the current fee, and if that value is greater than the current fee use c else just use fee

However, that expression is in a long winded check and makes code much harder to read unnecessarily

Suggestion

Just simply do

	for _, fee := range globalFees {
		// Check if there is already a global fee value denominated
     // in min_gas_price and greater than the current fee.
		ok, c := minGasPrices.Find(fee.Denom)
		if ok && c.Amount.GT(fee.Amount) {
			allFees = append(allFees, c)
		} else {
			allFees = append(allFees, fee)
		}
	}

Type

Impact

Less complex code, much easier to read, understand and maintain code

/cc @elias-orijtech

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?