Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

test gas estimation vs gas consumption #497

Open
noot opened this issue Sep 2, 2020 · 3 comments
Open

test gas estimation vs gas consumption #497

noot opened this issue Sep 2, 2020 · 3 comments

Comments

@noot
Copy link
Contributor

noot commented Sep 2, 2020

Proposal: [Description of the feature]

see #458
this PR changed the gas estimation of a value transfer but not a contract deployment. we should test to see if the gas cost for a value transfer has changed (should be 21000) we should also add RPC tests for gas consumption.

Current behavior: [What currently happens]

Desired behavior: [What you would like to happen]

Use case: [Why is this important (helps with prioritizing requests)]

Requests may be closed if we're not actively planning to work on them.

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Oct 18, 2020
@fedekunze fedekunze added Status: On Ice Type: Enhancement and removed stale stale PRs that will be closed if no further action occurs labels Oct 18, 2020
@freddyli7
Copy link
Contributor

PR: #879

@freddyli7
Copy link
Contributor

After merging gas refund, the gas estimation is more then the actual gas cost. Some fix is needed. #879 is discarded and closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants