REST: tx/ vs tx/broadcast

[alexanderbez]

Summary

Not sure if this is intended, but there seems to be overlap between the POST @ /tx endpoint and the POST @ tx/broadcast endpoint, where the former seems more flexible as it allows for sync/async/block. Assuming this is not intended, the latter should be removed.

Proposal

// x/auth/client/rest/query.go

        // this should be removed altogether 
	r.HandleFunc(
		"/tx/broadcast",
		BroadcastTxRequestHandlerFn(cdc, cliCtx),
	).Methods("POST")

        // this should be moved to client/tx.go
	r.HandleFunc(
		"/tx/encode",
		EncodeTxRequestHandlerFn(cdc, cliCtx),
	).Methods("POST")

/cc @jackzampolin @cosmos/cosmos-ui

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[jackzampolin]

I'm comfortable removing the endpoint with less functionality.

[jackzampolin]

Sorry abt the close! Hit the wrong button it looks like 🤦‍♂️