Wrong error result from REST endpoint

[faboweb]

Summary of Bug

POST /txs/broadcast returns a bad error response.

Actual (JSON with a string containing a stringified JSON):

{"message":"Msg 0 failed: {\"codespace\":\"sdk\",\"code\":10,\"message\":\"10stake \\u003c 99stake\"}"}

Expected (parsable JSON with human readable error message):

{"codespace":"sdk","code":10,"message":"You are trying to send more stake than you own. You own: 10stake. You tryed to send: 99stake"}"}

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

This seems like a duplicate of #2953.

[jackzampolin]

Closing this as a duplicate.

[faboweb]

Reopening because of pending discussion about this.

[alexanderbez]

@faboweb I do think we should close this issue and a corresponding issue should be opened in Tendermint as that serves a broader audience as it'll have larger implications. Then, another corresponding issue on the SDK can be opened which addresses the generic usage of Log as a map. This just focuses on errors. Again, I recommend we close. cc @jackzampolin

[jackzampolin]

@faboweb Happy to talk about this in depth on our next call, but I've personally investigated fixing exactly what's bugging you twice and it is a tendermint issue.

[alexanderbez]

Sorry for the mass miscommunication. From today's conversation, what we need to do is:

Since the log will always be valid JSON, thanks to #3606, we must intercept this value in sdk.Result which is a string and convert it to a map[string]interface{} before returning it.

[alexanderbez]

#3688 doesn't actually solve this and I made another issue with a bit more in depth analysis here: #3693. I will close this and further work should be tracked on that issue. #3688 should still be merged though.