Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdk.Context to Authorization.Accept method and charge gas for expensive authorizations #8984

Closed
aaronc opened this issue Mar 24, 2021 · 1 comment · Fixed by #8995
Closed
Assignees
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Mar 24, 2021

In #8563, we are adding sdk.Context to FeeAllowanceI in order to be able to ConsumeGas now and perform read-only queries in the future.

For x/authz, let's:

  • change the Authorization.Accept interface to:
Accept(ctx sdk.Context, msg sdk.ServiceMsg) (updated Authorization, delete bool, err error)
  • charge gas for the loops in StakeAuthorization.

We may also want to add ValidateBasic to Authorization specifically for StakeAuthorization.

@clevinson
Copy link
Contributor

@robert-zaremba to support on investigating gas table based recommendations for what the incremental gas charge # should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants