Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-validator cli command should take in a json file (or validator config file) #8177

Closed
4 tasks
colin-axner opened this issue Dec 16, 2020 · 4 comments · Fixed by #14864
Closed
4 tasks

Comments

@colin-axner
Copy link
Contributor

Summary

Creating a validator via command line can be tricky. There are a lot of required flags you need to specify. I'd propose changing the command so that it takes in a validator.json file that users can modify with their desired fields. That way we can specify defaults but it is easy for the creator to see which fields they can modify. We can provide an initial validator.json with missing required fields to ensure they modify the file.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@anilcse
Copy link
Collaborator

anilcse commented Dec 17, 2020

+1
I wonder why we have many flags required for create-validator cmd but not for gentx command. @alexanderbez is this just overlooked or is there any reason?

@alexanderbez
Copy link
Contributor

I think this is just poor UX design. So many required flags is an indication of poor design choice in this command. I think having a single arg validator.json is a much better UX as you've suggested 👍

@anilcse
Copy link
Collaborator

anilcse commented Dec 22, 2020

I think we can make moniker, amount flags as required and keep other flags as optional (same as gentx command). Also, we can have a flag to read from file may be? imho, creating a file is bit odd-experience for users.

@alexanderbez
Copy link
Contributor

The thing is, having a bunch of required flags is an indicator that they should be args, and if you have a bunch of args the UX for that command becomes pretty ugly now.

@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 16, 2023
@likhita-809 likhita-809 self-assigned this Jan 19, 2023
@likhita-809 likhita-809 moved this from 📝 Todo to 👀 Needs Review in Cosmos-SDK Feb 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Feb 22, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants