Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ed25519 backend #7890

Closed
4 tasks
robert-zaremba opened this issue Nov 11, 2020 · 6 comments · Fixed by #8690
Closed
4 tasks

Update ed25519 backend #7890

robert-zaremba opened this issue Nov 11, 2020 · 6 comments · Fixed by #8690

Comments

@robert-zaremba
Copy link
Collaborator

Summary

Tendermint v0.35 (scheduled post Stargate) changed ed25519 backend to according to zip215
Details: tendermint/tendermint#5632

Problem Definition

For compatibility with other libraries we need to have more strict signature verification than the default one provided by stdlib.

Proposal

Simple task: use github.com/hdevalence/ed25519consensus (instead of stdlib) for ed25519 signature verification.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v0.40.1 milestone Nov 11, 2020
@robert-zaremba
Copy link
Collaborator Author

@marbar3778 - is Tendermint v0.35 scheduled for SDK 0.40.1 or 0.41.0?

@tac0turtle
Copy link
Member

tac0turtle commented Nov 11, 2020

Does the sdk have a timetable for 0.41. It's hard to say when 0.35 will be ready

@robert-zaremba robert-zaremba modified the milestones: v0.40.1, v0.41 Nov 11, 2020
@robert-zaremba
Copy link
Collaborator Author

We have a task list https://github.com/cosmos/cosmos-sdk/milestone/26 :D
But I think we can do it earlier. It should be compatible, right?

@tac0turtle
Copy link
Member

Yea it should be compatible. I dont think the sdk does any key verification for tm ed25519 keys? If this is the case, it is safe to make this update now.

@robert-zaremba
Copy link
Collaborator Author

I'm not aware about any such place. @aaronc - do you know if we do that ?

@aaronc aaronc modified the milestones: v0.41, v0.42 Jan 6, 2021
@robert-zaremba
Copy link
Collaborator Author

There is also a security discussion about ed25519 in #4789

@tac0turtle tac0turtle mentioned this issue Feb 24, 2021
9 tasks
@mergify mergify bot closed this as completed in #8690 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants