Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write simulations for evidence module #5961

Closed
4 tasks
fedekunze opened this issue Apr 8, 2020 · 2 comments · Fixed by #6035
Closed
4 tasks

Write simulations for evidence module #5961

fedekunze opened this issue Apr 8, 2020 · 2 comments · Fixed by #6035

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Apr 8, 2020

Summary

x/evidence module is missing the simulation/ package required to run simulations for the module

Problem Definition

Simulations are not running evidence module operations.

Proposal

  1. Write the following simulation functions for evidence module and register them in x/evidence/module.go:
  • Randomized genesis state
  • Store decoders
  • Weighted operations
  1. Add x/evidence simulations to SDK Simapp
  2. Add x/evidence simulations to Gaia

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

alexanderbez commented Apr 8, 2020

There is nothing to simulate atm. Clients cannot arbitrarily submit any evidence they like. You'll see the following in simapp:

	// create evidence keeper with router
	evidenceKeeper := evidence.NewKeeper(
		appCodec, keys[evidence.StoreKey], app.subspaces[evidence.ModuleName], &app.StakingKeeper, app.SlashingKeeper,
	)
	evidenceRouter := evidence.NewRouter()
	// TODO: Register evidence routes.
	evidenceKeeper.SetRouter(evidenceRouter)
	app.EvidenceKeeper = *evidenceKeeper

@fedekunze
Copy link
Collaborator Author

There is nothing to simulate atm. Clients cannot arbitrarily submit any evidence they like.

👍I'll remove the weighted operations then

@fedekunze fedekunze self-assigned this Apr 17, 2020
@mergify mergify bot closed this as completed in #6035 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants