Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Ante handler to router and dont panic if nil #557

Closed
ebuchman opened this issue Mar 3, 2018 · 1 comment
Closed

Move Ante handler to router and dont panic if nil #557

ebuchman opened this issue Mar 3, 2018 · 1 comment
Assignees
@sunnya97
Labels
C:baseapp S:proposed

Comments

@ebuchman
Copy link
Member

ebuchman commented Mar 3, 2018 •
edited
Loading

Currently the BaseApp will panic if the AnteHandler is nil but doesn't take it in the constructor. We don't really want to add it in the constructor either. So let's do SetAnte on the router :)

Relates to #480

See more complete description in #559
This was referenced Mar 3, 2018
Closed
Closed
@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@ebuchman
Copy link
Member Author

ebuchman commented Jul 7, 2018

Will close for now but we should revisit soon in the context of possible changes to the BaseApp API to better separate concerns.

@ebuchman ebuchman closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunnya97 sunnya97

Labels
C:baseapp S:proposed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sunnya97 @ebuchman @cwgoes