Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pagination for Governance Votes #5344

Closed
2 of 4 tasks
alexanderbez opened this issue Nov 29, 2019 · 4 comments · Fixed by #5405
Closed
2 of 4 tasks

Support Pagination for Governance Votes #5344

alexanderbez opened this issue Nov 29, 2019 · 4 comments · Fixed by #5405

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 29, 2019

Summary

Support pagination for /gov/{proposalID}/votes. The pagination should support not only the querier but also the tx event query (i.e. pagination should be proxied to the tx event query).

ref: #5212


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dshulyak
Copy link
Contributor

hey @alexanderbez . do you want to work on this one yourself? or it is free to take? I am looking for a places to contribute, and perhaps can help with this one

@alexanderbez alexanderbez removed their assignment Dec 12, 2019
@alexanderbez
Copy link
Contributor Author

Please @dshulyak, would love any contribution here! Let me know if you have any questions. It should be pretty straightforward -- see other pagination handlers for example :)

@dshulyak
Copy link
Contributor

@alexanderbez does it make sense to add pagination support for Deposits as well?

@alexanderbez
Copy link
Contributor Author

@dshulyak yes, I believe we'll need the same for deposits 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants