Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undelegate losing tokens issue #4553

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Conversation

helldealer
Copy link
Contributor

fix the issue
Undelegate may lose the delegator’s tokens when exceed the MaxEntries of unbonding delegations #4551

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #4553 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   53.47%   53.46%   -0.02%     
==========================================
  Files         257      257              
  Lines       16168    16168              
==========================================
- Hits         8646     8644       -2     
- Misses       6876     6878       +2     
  Partials      646      646

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review C:x/staking labels Jun 14, 2019
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! mind adding a clog entry too?

@alexanderbez alexanderbez merged commit 941effc into cosmos:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants