You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bulk, if not all, commands that support --generate-only call GenerateOrBroadcastMsgs. This internally is always passed offline: false, which is then passed to PrintUnsignedStdTx. Because offline: false, we then call buildUnsignedStdTx, which then calls PrepareTxBuilder. Finally, PrepareTxBuilder performs some node queries. Namely, it ensures the account exists.
I believe PrepareTxBuilder should remain as-is, but that PrintUnsignedStdTx never calls buildUnsignedStdTx.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
offline isn't really a thing @alessio. There's only the notion of generate-only. offline is only used during tx sign, in which case generate-only isn't applicable.
It kinda was, look at x/auth/client/cli/multisign.go and x/auth/client/cli/sign.go. The plan was to grow that feature into something more generic. See also: #3720
As discussed in chat, I think it should be OK to just update --generate-only docs and make clear that connectivity to the node is cut when the flag is up.
Summary of Bug
A bulk, if not all, commands that support
--generate-only
callGenerateOrBroadcastMsgs
. This internally is always passedoffline: false
, which is then passed toPrintUnsignedStdTx
. Becauseoffline: false
, we then callbuildUnsignedStdTx
, which then callsPrepareTxBuilder
. Finally,PrepareTxBuilder
performs some node queries. Namely, it ensures the account exists.I believe
PrepareTxBuilder
should remain as-is, but thatPrintUnsignedStdTx
never callsbuildUnsignedStdTx
.For Admin Use
The text was updated successfully, but these errors were encountered: