Minor cleanup in tx tags and response format #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
T: API Breaking
alexanderbez
commented
Apr 29, 2019
| @@ -45,7 +45,7 @@ type ABCIMessageLogs []ABCIMessageLog | |||
|
|
|||
| // ABCIMessageLog defines a structure containing an indexed tx ABCI message log. | |||
| type ABCIMessageLog struct { | |||
| MsgIndex int `json:"msg_index"` | |||
| MsgIndex uint16 `json:"msg_index"` | |||
There was a problem hiding this comment.
We change this to a uint16 for two reasons:
- We'll never exceed this anyway
- We're guaranteed this is encoded and decoded as an integer and not stringified first (due to Amino)
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
fedekunze
approved these changes
Apr 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #4230 +/- ##
==========================================
- Coverage 60.18% 60.16% -0.02%
==========================================
Files 212 212
Lines 15187 15187
==========================================
- Hits 9140 9138 -2
- Misses 5418 5420 +2
Partials 629 629 |
alessio
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: