Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove REST server's secure mode altogether #3938

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 19, 2019

It shouldn't be gaiacli REST server's responsibility to deal in secure layer's business.
We drop secure mode altogether.

As agreed with @zmanian.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review March 19, 2019 17:25
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #3938 into develop will increase coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #3938     +/-   ##
==========================================
+ Coverage    60.22%   60.32%   +0.1%     
==========================================
  Files          197      196      -1     
  Lines        14628    14488    -140     
==========================================
- Hits          8809     8740     -69     
+ Misses        5225     5167     -58     
+ Partials       594      581     -13

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, looks fine to me.

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this effort to nginx (or any other proxy) 👍

@cwgoes cwgoes merged commit b9837e3 into develop Mar 19, 2019
@cwgoes cwgoes deleted the lcd-remove-secure-mode branch March 19, 2019 21:00
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗡+5,-349 🔪 LGTM! This is the type of PR I like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants