Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly return error in unmarshal functions #3810

Closed
jackzampolin opened this issue Mar 5, 2019 · 0 comments · Fixed by #3806
Closed

Properly return error in unmarshal functions #3810

jackzampolin opened this issue Mar 5, 2019 · 0 comments · Fixed by #3806

Comments

@jackzampolin
Copy link
Member

In some unmarshal functions we aren't returning the error properly:

if err != nil {
  return nil
}

These instances should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant