Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accounts to store deposits within Governance #3628

Closed
rigelrozanski opened this issue Feb 12, 2019 · 4 comments · Fixed by #4255
Closed

Remove accounts to store deposits within Governance #3628

rigelrozanski opened this issue Feb 12, 2019 · 4 comments · Fixed by #4255
Assignees
Labels
Milestone

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Feb 12, 2019

Currently we use auth accounts to store deposits within governance, this should be updated to use a running tally, similar to how staking tracks coins.

REF: #3567

CC @sunnya97

@alexanderbez
Copy link
Contributor

@sunnya97 mind if I take a stab at this?

@sunnya97
Copy link
Member

@alexanderbez This requires fixing the bank module to track total supply instead of the staking module. Essentially redoing PR #2939 that was pushed post launch.

However, that is probably out of scope for v0.34.0 @jackzampolin

@alexanderbez
Copy link
Contributor

Ok, great. Thank you for the update. Removing this from v0.34 then as this is a non-trivial modification.

@alexanderbez alexanderbez modified the milestones: v0.34.0, Backlog Mar 25, 2019
@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented Mar 25, 2019

@sunnya97 oh okay I think I understand, the total supply calculated by staking doesn't know about the coins stored in deposits - hence we need a generic way (in bank) to calculate total supply which different modules can register special functionality with.

This Issue is blocked by #3972

@rigelrozanski rigelrozanski added the S:blocked Status: Blocked label Mar 25, 2019
@fedekunze fedekunze self-assigned this May 2, 2019
@fedekunze fedekunze removed the S:blocked Status: Blocked label May 2, 2019
@fedekunze fedekunze mentioned this issue May 2, 2019
5 tasks
@fedekunze fedekunze mentioned this issue May 26, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants