"gaia tx sign adrian.json --validate-signatures" always returns OK

[adrianbrink]

Summary of Bug

gaia tx sign adrian.json --validate-signatures does not work. It returns OK even if the signature data is missing.

Steps to Reproduce

Run gaia tx sign adrian.json --validate-signatures against either transaction.

Original content and signature

{
    "type": "auth/StdTx",
    "value": {
      "msg": [
        {
          "type": "cosmos-sdk/MsgCreateValidator",
          "value": {
            "Description": {
              "moniker": "Cryptium Labs",
              "identity": "5A309B5CA189D8B3",
              "website": "https://cryptium.ch/",
              "details": ""
            },
            "Commission": {
              "rate": "1.0000000000",
              "max_rate": "1.0000000000",
              "max_change_rate": "1.0000000000"
            },
            "delegator_address": "cosmos1eysta0x7quczxkecrm6f36assewqddr0879wgv",
            "validator_address": "cosmosvaloper1eysta0x7quczxkecrm6f36assewqddr0z23myl",
            "pubkey": {
              "type": "tendermint/PubKeyEd25519",
              "value": "5I1f+SucFbnCuL5DV5g0xuQws5/oPgKf9UtXRk47+co="
            },
            "delegation": {
              "denom": "STAKE",
              "amount": "10000"
            }
          }
        }
      ],
      "fee": {
        "amount": [
          {
            "denom": "",
            "amount": "0"
          }
        ],
        "gas": "200000"
      },
      "signatures": [
        {
          "pub_key": {
            "type": "tendermint/PubKeySecp256k1",
            "value": "ApMbpXOltvp26VnVYUCmU6jPiIviNUDItOD2nsmRvtKF"
          },
          "signature": "Ts3C1iGqGue5G+Btxmn+qADn0A0JCZDgLncPgEVNDYJHXzIQApFNPmKtuVd6XEFs6iShBWNcB45psIjZGIRIMQ==",
          "account_number": "0",
          "sequence": "0"
        }
      ],
      "memo": "29cca3d3189ea2caf8ea7534d8f791f8f9d34a99@192.168.95.231:26656"
    }
}

Changed content and signature data missing

{
    "type": "auth/StdTx",
    "value": {
      "msg": [
        {
          "type": "cosmos-sdk/MsgCreateValidator",
          "value": {
            "Description": {
              "moniker": "Cryptium Labs",
              "identity": "5A309B5CA189D8B3",
              "website": "https://cryptium.ch/",
              "details": ""
            },
            "Commission": {
              "rate": "1.0000000000",
              "max_rate": "1.0000000000",
              "max_change_rate": "1.0000000000"
            },
            "delegator_address": "cosmos1eysta0x7quczxkecrm6f36assewqddr0879wgv",
            "validator_address": "cosmosvaloper1eysta0x7quczxkecrm6f36assewqddr0z23myl",
            "pubkey": {
              "type": "tendermint/PubKeyEd25519",
              "value": "5I1f+SucFbnCuL5DV5g0xuQws5/oPgKf9UtXRk47+co="
            },
            "delegation": {
              "denom": "STEAK",
              "amount": "10000"
            }
          }
        }
      ],
      "fee": {
        "amount": [
          {
            "denom": "",
            "amount": "0"
          }
        ],
        "gas": "200000"
      },
      "signatures": [
        {
          "pub_key": {
            "type": "tendermint/PubKeySecp256k1",
            "value": "ApMbpXOltvp26VnVYUCmU6jPiIviNUDItOD2nsmRvtKF"
          },
          "account_number": "0",
          "sequence": "0"
        }
      ],
      "memo": "29cca3d3189ea2caf8ea7534d8f791f8f9d34a99@192.168.95.231:26656"
    }
}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

/cc @alessio

[alexanderbez]

I can take a look at this.