Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock binary dependencies to a specific commits / versions #2464

Merged
merged 7 commits into from
Oct 12, 2018
Merged

Lock binary dependencies to a specific commits / versions #2464

merged 7 commits into from
Oct 12, 2018

Conversation

ValarDragon
Copy link
Contributor

This is basically copying over @anton's great script!

Also had to run make format to make this pass test_lint.
This PR also makes the make commands for tools further align
with the tendermint implementation.

closes #1809

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests - n/a

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
Lock binary dependencies to a specific commits / versions
9e334af 
This is basically copying over @anton's great script!

Also had to run `make format` to make this pass `test_lint`.
This PR also makes the make commands for tools further align
with the tendermint implementation.
@codecov
Copy link

codecov bot commented Oct 10, 2018 •
edited
Loading

Codecov Report

Merging #2464 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop   #2464   +/-   ##
=======================================
  Coverage     61.9%   61.9%           
=======================================
  Files          149     149           
  Lines         9530    9530           
=======================================
  Hits          5900    5900           
  Misses        3213    3213           
  Partials       417     417

@cwgoes
Copy link
Contributor

cwgoes commented Oct 10, 2018 •
edited
Loading

Hmm, make get_dev_tools fails now... (see CI)

@ValarDragon
Copy link
Contributor Author

Fixed, it was an issue with the circle config. I hadn't realized lint didn't already have make get_tools ran.

cwgoes
cwgoes suggested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor questions.

Makefile Outdated Show resolved Hide resolved
tools/gometalinter.json Show resolved Hide resolved
scripts/get_tools.sh Outdated
# specific git hash.
#
# repos it installs:
# github.com/mitchellh/gox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so? Maybe this comment was copied from Tendermint?

@cwgoes
Copy link
Contributor

cwgoes commented Oct 11, 2018 •
edited
Loading

Now this is causing make test_lint to fail though (see CI).

Did we pick the revision we're using on develop at the moment?

@ValarDragon
Copy link
Contributor Author

Oh I didn't use our golint :l. I'm not a fan of tendermint/golint (which is only used in the sdk) being a thing :l

@ValarDragon
Copy link
Contributor Author

ValarDragon commented Oct 11, 2018 •
edited
Loading

I don't think its worth restructuring the script for tendermint/lint (as its download must come after gometalinter installs linters). Reasoning I don't think its worth restructuring 1 because its our own repo, and 2 we're planning on phasing that out anyway (once someone gets time, or postlaunch). Because of that, I'll implement a slightly more "hacky" solution, which I don't actually think is bad

@cwgoes cwgoes merged commit 7e9c39e into develop Oct 12, 2018
@cwgoes cwgoes deleted the dev/lock_tools branch October 12, 2018 20:55
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tools: Make all binaries use tagged versions
2 participants
@ValarDragon @cwgoes