simulation: Use a simulation.Account struct #2384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
This removes privkeys and addresses from function signatures. This comes with a 11% performance improvement to the simulator, as we no longer keep recomputing the pubkeys. Once we move the transient store clearing to endblock, we can further raise the size of make test_sim_gaia_fast concretely, `make test_sim_gaia_fast` went from 16.8 seconds to 13.5 seconds on my system.
ValarDragon
force-pushed
the
dev/simulation_remove_pubkey_ops
branch
from
16325d8
to
bb624b3
Compare
ValarDragon
requested review from
alexanderbez
and removed request for
ebuchman
alexanderbez
approved these changes
Sep 24, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2384 +/- ##
===========================================
+ Coverage 63.54% 64.49% +0.95%
===========================================
Files 120 138 +18
Lines 7236 8619 +1383
===========================================
+ Hits 4598 5559 +961
- Misses 2326 2685 +359
- Partials 312 375 +63 |
|
Merged bb624b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes privkeys and addresses from function signatures.
This comes with a 11% performance improvement to the simulator,
as we no longer keep recomputing the pubkeys.
Once we move the transient store clearing to endblock, we can
further raise the size of make test_sim_gaia_fast
concretely,
make test_sim_gaia_fastwent from 16.8 seconds to 13.5 seconds on my system.docs/) - no simulator docs yet, I'll probably make some soon. Godocs were updatedPENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: