Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular dep between client/v2 and x/gov #22865

Closed
julienrbrt opened this issue Dec 13, 2024 · 0 comments · Fixed by #22867
Closed

Remove circular dep between client/v2 and x/gov #22865

julienrbrt opened this issue Dec 13, 2024 · 0 comments · Fixed by #22867
Assignees
@julienrbrt

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Dec 13, 2024 •
edited
Loading

#22775 introduce a circular dep between x/gov and client/v2

  • x/gov & x/group require client/v2 for the prompts commands
  • client/v2 requires x/gov for creating proposal for any commands

This got noticed during the release prep, and should be removed before rc.
@julienrbrt julienrbrt self-assigned this Dec 13, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Legacy Dec 13, 2024
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Dec 13, 2024
@julienrbrt julienrbrt mentioned this issue Dec 13, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Legacy Dec 13, 2024
@mergify mergify bot mentioned this issue Dec 13, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
None yet
Projects
No open projects
Cosmos-SDK Legacy
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(client/v2): remove gov dependency cosmos/cosmos-sdk
1 participant
@julienrbrt