simulation: Write logs on panic #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
ValarDragon
commented
Sep 9, 2018
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| dbm "github.com/tendermint/tendermint/libs/db" |
There was a problem hiding this comment.
Linting was failing here, so I just ran make format.
Codecov Report
@@ Coverage Diff @@
## develop #2285 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 140 140
Lines 8682 8682
========================================
Hits 5546 5546
Misses 2756 2756
Partials 380 380 |
alessio
reviewed
Sep 10, 2018
| fmt.Printf("Exiting early due to SIGTERM, on block %d, operation %d\n", header.Height, opCount) | ||
| DisplayEvents(events) | ||
| os.Exit(128 + int(syscall.SIGTERM)) | ||
| fmt.Printf("Exiting early due to SIGTERM/SIGINT, on block %d, operation %d\n", header.Height, opCount) |
There was a problem hiding this comment.
Why not:
sig := <-c
fmt.Printf("Exiting early due to %s, on block %d, operation %d\n", sig, header.Height, opCount)
alessio
reviewed
Sep 10, 2018
| DisplayEvents(events) | ||
| os.Exit(128 + int(syscall.SIGTERM)) | ||
| fmt.Printf("Exiting early due to SIGTERM/SIGINT, on block %d, operation %d\n", header.Height, opCount) | ||
| simError = errors.New("Exited due to SIGTERM/SIGINT") |
|
Is this PR ready to go? Seems like this is necessary for debugging some of the bugs simulation uncovered. |
|
Yup this should be good to merge, pending review / approval. Anyone whose debugging can just directly use this branch for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the logs are large, it gets written to a file. Additionally, this PR also does a slight refactor so that simulation returns an error. This means when we do SIGTERM/ SIGINT the database cleanup code still gets ran.
Targeted PR against correct branch (see CONTRIBUTING.md)
Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: