You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently modules under x/ have following dependencies:
Bank: Auth for accessing accounts
Gov: Bank for modifying balances
Slashing: Params for retrieving parameters
Stake: Bank for modifying balances
To reduce the dependencies, we must import interface that satisfies the needs, not the keeper struct itself. We are doing it for stake module, and allso see #1528
So instead of importing bank.CoinKeeper from bank, we can define type CoinKeeper interface in types/(since it is needed widely) and import that.
The text was updated successfully, but these errors were encountered:
As per discussions with @sunnya97 we should probably define a new layer of abstraction for the common interfaces which all modules anticipated to be working together fulfill (kind of like a types/ dir for a group of modules). You should sync with sunny on this one for sure!
Currently modules under
x/
have following dependencies:Bank
:Auth
for accessing accountsGov
:Bank
for modifying balancesSlashing
:Params
for retrieving parametersStake
:Bank
for modifying balancesTo reduce the dependencies, we must import interface that satisfies the needs, not the keeper struct itself. We are doing it for stake module, and allso see #1528
So instead of importing
bank.CoinKeeper
frombank
, we can definetype CoinKeeper interface
intypes/
(since it is needed widely) and import that.The text was updated successfully, but these errors were encountered: