Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all modules get their logger through depinject/NewKeeper instead of context #15911

Closed
facundomedica opened this issue Apr 21, 2023 · 2 comments
Closed

Make all modules get their logger through depinject/NewKeeper instead of context #15911

facundomedica opened this issue Apr 21, 2023 · 2 comments
Assignees
@facundomedica
Labels
T:feature-request

Comments

@facundomedica
Copy link
Member

Summary

Opened this issue to track the continuation of #15818 for every module

Problem Definition

Proposal
@facundomedica facundomedica self-assigned this Apr 24, 2023
@tac0turtle
Copy link
Member

i think we should reevaluate this, im starting to think passing this all in could be annoying instead of just passing it on the context, we can define the interface for context in core too

@tac0turtle
Copy link
Member

done in env var migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
T:feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facundomedica @tac0turtle