Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proto-gen #15267

Closed
chixiaowen opened this issue Mar 6, 2023 · 4 comments · Fixed by #15268
Closed

make proto-gen #15267

chixiaowen opened this issue Mar 6, 2023 · 4 comments · Fixed by #15268

Comments

@chixiaowen
Copy link
Contributor

Summary of problem

when I execute the cmd make proto-gen, there is so many *pb.go files modified. *pb.go files are different. What impact will these have?

Version

main

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Mar 6, 2023
@julienrbrt julienrbrt added T:question and removed needs-triage Issue that needs to be triaged labels Mar 6, 2023
@julienrbrt
Copy link
Member

make proto-gen generates the protos in a temporary folder. The generated files are named *.pb.go.
If you wait until the command has finished running, the files will be moved to their right place and the diff should be smaller.

@chixiaowen
Copy link
Contributor Author

make proto-gen generates the protos in a temporary folder. The generated files are named *.pb.go. If you wait until the command has finished running, the files will be moved to their right place and the diff should be smaller.

I konw that, but when I execute make proto-gen,I have not modified any files,I found that as follow:
image
generated the new *pb.go files are not the same as main branch.

@yihuang
Copy link
Collaborator

yihuang commented Mar 6, 2023

Sometimes when the files are generated by different versions of tools, all the files get modified in a slight way, but usually not anything cause behavior changes

@julienrbrt
Copy link
Member

Sometimes when the files are generated different versions of tools, all the files get modified in a slight way, but usually not anything cause behavior changes

Yes, I have just run it myself and indeed I see this is just due to the update of protoc-gen-go-grpc to v1.3.0.
We can safely push that to main as there is no behavior changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants