Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual: Use Key+Value instead of simply Text #14665

Closed
Tracked by #11970
amaury1093 opened this issue Jan 18, 2023 · 0 comments · Fixed by #14730
Closed
Tracked by #11970

Textual: Use Key+Value instead of simply Text #14665

amaury1093 opened this issue Jan 18, 2023 · 0 comments · Fixed by #14730

Comments

@amaury1093
Copy link
Contributor

Summary

Part of #11970

Update the Textual SPEC so that a Screen holds two keys, Key and Value, instead of simply Text.

Problem Definition

Currently our Screen struct has 3 fields: Text, Indent and Expert. In Text, we put the whole content we want to show on (ideally) one device screen. It generally takes the <key>: <value> format, e.g. From address: cosmos1abc...def. Then, on the ledger device, we do some parsing to split using the : separator:

| From address
| cosmos1ab
| c...def

Proposal

To avoid splitting, we propose to switch Screen to use 2 fields, Key and Value. This will allow less string manipulation, and seems more in line with devices implementations of Title and Content. The CBOR encoding will also be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants