-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Tendermint v0.35.x to SDK v0.44 release branch #10580
Comments
Wouldn't introducing TM v0.35 into SDK v0.44 technically be a breaking change? Specifically, there are numerous APIs in TM that changed or were removed outright and as a result things changed in the SDK to accommodate that. |
It would need to be 0.45. But we can still do that in a backport way if needed. |
Tendermint has a few changes that need to be implemented and taken into consideration. For ed25519 changes it is recommended to do a coordinated upgrade, otherwise there are edge cases that can cause problems. There was also a db key migration, users would need to migrate all keys in order to use 0.35 with 0.44. All in all, it is possible, but not recommended for live chains. |
Ah didn't realize there was a db migration needed |
yeah, this is what we were talking during the last Friday: breaking changes can't go into 0.44. Let's close this issue and open a new one if needed. |
Summary
On the SDK call today, we talked about backporting Tendermint v0.35.x into the SDK v0.44.x release line. (And maybe we need to tag this as SDK v0.45)
As shown in #10210 there is a lot of changes here. Doing this is mainly blocked on someone spending the time to produce the rebase. Should also backport PR that fixes #9962
Problem Definition
Prioritized mempool helps alot with TX fee issues. Further, the new p2p work is really helpful to be testing against to get more p2p issues solved on mainnets.
Proposal
Update SDK v0.44 branch to have Tendermint v0.35.
For Admin Use
The text was updated successfully, but these errors were encountered: