diff --git a/x/circuit/keeper/msg_server_test.go b/x/circuit/keeper/msg_server_test.go index aba95ee8e5fd..1ee1250d0da4 100644 --- a/x/circuit/keeper/msg_server_test.go +++ b/x/circuit/keeper/msg_server_test.go @@ -164,7 +164,7 @@ func TestAuthorizeCircuitBreakerWithPermissionValidation(t *testing.T) { require.Error(t, err) // grants user perms to Permissions_LEVEL_SOME_MSGS with empty LimitTypeUrls - permis := types.Permissions{Level: types.Permissions_LEVEL_SOME_MSGS, LimitTypeUrls: []string{"cosmos.staking.v1beta1.MsgDelegate", "/cosmos.gov.v1beta1.MsgDeposit", ""}} + permis := types.Permissions{Level: types.Permissions_LEVEL_SOME_MSGS, LimitTypeUrls: []string{"cosmos.staking.v1beta1.MsgDelegate", "/cosmos.gov.v1beta1.MsgDeposit", "cosmos.gov.v1beta1.MsgVote"}} msg = &types.MsgAuthorizeCircuitBreaker{Granter: authority, Grantee: addresses[4], Permissions: &permis} _, err = srv.AuthorizeCircuitBreaker(ft.ctx, msg) require.NoError(t, err) @@ -185,7 +185,7 @@ func TestAuthorizeCircuitBreakerWithPermissionValidation(t *testing.T) { perms, err = ft.keeper.Permissions.Get(ft.ctx, add4) require.NoError(t, err) - require.Equal(t, []string{"/cosmos.staking.v1beta1.MsgDelegate", "/cosmos.gov.v1beta1.MsgDeposit"}, perms.LimitTypeUrls) + require.Equal(t, []string{"/cosmos.staking.v1beta1.MsgDelegate", "/cosmos.gov.v1beta1.MsgDeposit", "/cosmos.gov.v1beta1.MsgVote"}, perms.LimitTypeUrls) } func TestTripCircuitBreaker(t *testing.T) { diff --git a/x/circuit/types/permission.go b/x/circuit/types/permission.go index 90a7ba4f13e8..bac736066c2d 100644 --- a/x/circuit/types/permission.go +++ b/x/circuit/types/permission.go @@ -24,8 +24,6 @@ func (p *Permissions) Validation() error { func MsgTypeURLValidation(urls []string) []string { for idx, url := range urls { if len(url) == 0 { - // remove this element - urls = append(urls[:idx], urls[idx+1:]...) continue } if url[0] != '/' {