diff --git a/schema/testing/statesim/app_diff.go b/schema/testing/statesim/app_diff.go index 93735093a7db..82628e550293 100644 --- a/schema/testing/statesim/app_diff.go +++ b/schema/testing/statesim/app_diff.go @@ -27,21 +27,21 @@ func DiffAppStates(expected, actual view.AppState) string { res += fmt.Sprintf("MODULE COUNT ERROR: expected %d, got %d\n", expectNumModules, actualNumModules) } - expected.Modules(func(expectedMod view.ModuleState, err error) bool { + for expectedMod, err := range expected.Modules { if err != nil { res += fmt.Sprintf("ERROR getting expected module: %s\n", err) - return true + continue } moduleName := expectedMod.ModuleName() actualMod, err := actual.GetModule(moduleName) if err != nil { res += fmt.Sprintf("ERROR getting actual module: %s\n", err) - return true + continue } if actualMod == nil { res += fmt.Sprintf("Module %s: actual module NOT FOUND\n", moduleName) - return true + continue } diff := DiffModuleStates(expectedMod, actualMod) @@ -49,9 +49,7 @@ func DiffAppStates(expected, actual view.AppState) string { res += "Module " + moduleName + "\n" res += indentAllLines(diff) } - - return true - }) + } return res } diff --git a/schema/testing/statesim/module_diff.go b/schema/testing/statesim/module_diff.go index 29ee19fb01a9..6570b900be29 100644 --- a/schema/testing/statesim/module_diff.go +++ b/schema/testing/statesim/module_diff.go @@ -27,21 +27,21 @@ func DiffModuleStates(expected, actual view.ModuleState) string { res += fmt.Sprintf("OBJECT COLLECTION COUNT ERROR: expected %d, got %d\n", expectedNumObjectCollections, actualNumObjectCollections) } - expected.ObjectCollections(func(expectedColl view.ObjectCollection, err error) bool { + for expectedColl, err := range expected.ObjectCollections { if err != nil { res += fmt.Sprintf("ERROR getting expected object collection: %s\n", err) - return true + continue } objTypeName := expectedColl.ObjectType().Name actualColl, err := actual.GetObjectCollection(objTypeName) if err != nil { res += fmt.Sprintf("ERROR getting actual object collection: %s\n", err) - return true + continue } if actualColl == nil { res += fmt.Sprintf("Object Collection %s: actuall collection NOT FOUND\n", objTypeName) - return true + continue } diff := DiffObjectCollections(expectedColl, actualColl) @@ -49,9 +49,7 @@ func DiffModuleStates(expected, actual view.ModuleState) string { res += "Object Collection " + objTypeName + "\n" res += indentAllLines(diff) } - - return true - }) + } return res } diff --git a/schema/testing/statesim/object_coll_diff.go b/schema/testing/statesim/object_coll_diff.go index cfd33b0b2a40..ce4f87efbef7 100644 --- a/schema/testing/statesim/object_coll_diff.go +++ b/schema/testing/statesim/object_coll_diff.go @@ -4,7 +4,6 @@ import ( "fmt" "strings" - "cosmossdk.io/schema" schematesting "cosmossdk.io/schema/testing" "cosmossdk.io/schema/view" ) @@ -30,21 +29,21 @@ func DiffObjectCollections(expected, actual view.ObjectCollection) string { res += fmt.Sprintf("OBJECT COUNT ERROR: expected %d, got %d\n", expectedNumObjects, actualNumObjects) } - expected.AllState(func(expectedUpdate schema.ObjectUpdate, err error) bool { + for expectedUpdate, err := range expected.AllState { if err != nil { res += fmt.Sprintf("ERROR getting expected object: %s\n", err) - return true + continue } keyStr := fmtObjectKey(expected.ObjectType(), expectedUpdate.Key) actualUpdate, found, err := actual.GetObject(expectedUpdate.Key) if err != nil { res += fmt.Sprintf("Object %s: ERROR: %v\n", keyStr, err) - return true + continue } if !found { res += fmt.Sprintf("Object %s: NOT FOUND\n", keyStr) - return true + continue } if expectedUpdate.Delete != actualUpdate.Delete { @@ -52,7 +51,7 @@ func DiffObjectCollections(expected, actual view.ObjectCollection) string { } if expectedUpdate.Delete { - return true + continue } valueDiff := schematesting.DiffObjectValues(expected.ObjectType().ValueFields, expectedUpdate.Value, actualUpdate.Value) @@ -62,9 +61,7 @@ func DiffObjectCollections(expected, actual view.ObjectCollection) string { res += "\n" res += indentAllLines(valueDiff) } - - return true - }) + } return res }