Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google's Protobuf well-known types definitions instead of prost_types #185

Closed
stevenatcrypto opened this issue Mar 29, 2022 · 2 comments

Comments

@stevenatcrypto
Copy link
Contributor

According to this recent PR of ibc-rs, should we also use Google's Protobuf well-known types definitions instead of prost_types to derive Serialize and Deserialize? Thanks.

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Apr 4, 2022

This feels like something that needs to be changed in tendermint-rs/tendermint-proto first, and we can follow suit. Otherwise we can't interop with their protos.

@tony-iqlusion
Copy link
Member

Here's an upstream issue on tendermint-rs: informalsystems/tendermint-rs#1053

I'd suggest any further discussion happens there. The crates in this repo will adopt whatever solution is used upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants