Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot (.) in schema field name allowed? #643

Open
Chris75forumname opened this issue Jun 14, 2023 · 6 comments
Open

Dot (.) in schema field name allowed? #643

Chris75forumname opened this issue Jun 14, 2023 · 6 comments

Comments

@Chris75forumname
Copy link

Chris75forumname commented Jun 14, 2023

I used a dot in a schema field name, e.g. xxx aka. yyy. I found, that struct inline editor did not work on this field. It did again, after I removed the dot. However, I couldn't find any documentation on naming convention for schema field names.

@Chris75forumname Chris75forumname changed the title Dot in schema field name allowed? Dot . in schema field name allowed? Jun 14, 2023
@Chris75forumname Chris75forumname changed the title Dot . in schema field name allowed? Dot (.) in schema field name allowed? Jun 14, 2023
@annda
Copy link
Contributor

annda commented Jul 27, 2023

Dot in a field name should work. I just tested ii and the inline editor in aggregations works. Can you provide more information? Field type? Is is a simple aggregation?

@Chris75forumname
Copy link
Author

Sorry, I cannot reproduce this bug myself, anymore. Nevermind.

@Chris75forumname
Copy link
Author

Chris75forumname commented Aug 14, 2023

I found the bug again. And, now I did more testing. (I tested this with current versions of dokuwiki and struct. I tested struct aggregation table and struct aggregation editor with fieldtype text.)

If dot occurs in field name like so: No. of items, inline editor does not show up on that field in struct serial editor upon doubleclick. However if field name is items and label is No. of items, inline editor works as expected.

Also filter breaks, if field name with (.) or label with (.) is used in the filter instruction.
If underlying schema field name is free of (.) and is used for the filter instruction, instead of label with (.), filter works as expected.

This should be mentioned in the documentation or solved in the code.

@splitbrain
Copy link
Member

We can not reproduce any problems with inline editing. When filtering, you need to give the full qualified name (with schema):

---- struct table ----
schema: test
cols: %pageid%, *
filter: test.text.foo ~ *aaa*
----

Seems to work, maybe it would be worth to update the documentation to recommend against using dots in field names.

@splitbrain
Copy link
Member

Please add a reproducible example if you still have problems.

@Chris75forumname
Copy link
Author

I edited the docs, accordingly. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants