Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno package support #263

Closed
jorjun opened this issue Nov 8, 2022 · 6 comments
Closed

Deno package support #263

jorjun opened this issue Nov 8, 2022 · 6 comments

Comments

@jorjun
Copy link

jorjun commented Nov 8, 2022

In my Deno project I can import like this:

import { AstroTime, Seasons } from "https://cdn.skypack.dev/astronomy-engine?dts";

But no types are getting through..

Wonder if it would be straightforword to package here: https://deno.land/add_module

@cosinekitty
Copy link
Owner

The Node/Deno package side of things is very far outside my expertise. As a general idea, I would prefer to positively diagnose the issue before trying to fix it. If I understand correctly, there is something wrong with the TypeScript declarations not coming through for you in Deno, even though they should be included in the npm package. Can you provide some more details about the issue with types?

@matheo, can you provide some assistance with this one? It would be greatly appreciated... I don't know what to ask or how to approach this issue.

@matheo
Copy link
Collaborator

matheo commented Nov 8, 2022

@cosinekitty it seems that typings field is not enough
maybe we need to rename it to types and that will fix the issue
https://docs.skypack.dev/package-authors/package-checks#types

I'm creating a PR ;)

@cosinekitty
Copy link
Owner

cosinekitty commented Nov 9, 2022

I just published the npm package for Astronomy Engine v2.1.9 including the pull request from @matheo. I'm reopening the issue until @jorjun can confirm it really works. Please let us know whether this solves your issue in Deno.

@cosinekitty cosinekitty reopened this Nov 9, 2022
@jorjun
Copy link
Author

jorjun commented Nov 9, 2022

Thanks so much for rapid resolution. Yep, all good with the following import.

import { Body, Ecliptic, GeoVector } from "https://esm.sh/v97/astronomy-engine@2.1.9"

@jorjun jorjun closed this as completed Nov 9, 2022
@cosinekitty
Copy link
Owner

Thank you very much @matheo! This was a huge help.

@matheo
Copy link
Collaborator

matheo commented Nov 9, 2022

Thanks to you @cosinekitty for the great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants