Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better observability #95

Closed
3 tasks done
coryodaniel opened this issue Nov 10, 2020 · 2 comments · Fixed by #128 · May be fixed by #129
Closed
3 tasks done

Better observability #95

coryodaniel opened this issue Nov 10, 2020 · 2 comments · Fixed by #128 · May be fixed by #129
Milestone
1.1

Comments

@coryodaniel
Copy link
Owner

coryodaniel commented Nov 10, 2020 •
edited by mruoss
Loading

  • remove notion, replace telemetry
  • add open telemetry API for tracing
  • structured logs + a library: :k8s so users can filter logs
@coryodaniel coryodaniel added this to the 1.0 milestone Nov 10, 2020
@coryodaniel coryodaniel changed the title Better telemetry integration Better observability Nov 10, 2020
@coryodaniel coryodaniel modified the milestones: 1.0, 1.1 Nov 10, 2020
@mruoss
Copy link
Collaborator

mruoss commented Feb 16, 2022

remove notion, replace with telemetry

absolutely!

add open telemetry API for tracing

YES! But maybe as a separate module? Some might want opentelemetry, others spandex,...

structured logs + a library: :k8s so users can filter logs

I think log formatting is up to the application, not the library. But adding default metadata for sure.

@mruoss mruoss linked a pull request Feb 16, 2022 that will close this issue
Telemetry and Logging #128
Merged
@mruoss
Copy link
Collaborator

mruoss commented Feb 16, 2022

YES! But maybe as a separate module? Some might want opentelemetry, others spandex,...

Or optional dependency...

@mruoss mruoss mentioned this issue Feb 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
2 participants
@coryodaniel @mruoss